fix(files): Check if target path is a descendant of the shared folder #47756
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
solracsf
added
2. developing
solracsf
requested review from
icewind1991,
a team,
skjnldsv,
yemkareems,
susnux,
come-nc and
provokateurin
and removed request for
a team
susnux
approved these changes
Sep 4, 2024
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
provokateurin
approved these changes
Sep 5, 2024
solracsf
added
2. developing
solracsf
force-pushed
the
fixingPathShareCheck
branch
from
3cd9e0f
to
014c6e6
Compare
solracsf
added
3. to review
solracsf
force-pushed
the
fixingPathShareCheck
branch
from
014c6e6
to
f7a3fd6
Compare
|
/backport to stable30 |
|
/backport to stable29 |
This comment was marked as outdated.
This comment was marked as outdated.
solracsf
force-pushed
the
fixingPathShareCheck
branch
from
f7a3fd6
to
2cf3087
Compare
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
|
Well, the report is about 29 only, and that function was reworked on 29 only at that time (no backport to 28). So, I believe 28 is not affected. |
|
Ok, sounds good then. |
susnux
approved these changes
Sep 5, 2024
susnux
added
4. to release
…lder path Signed-off-by: Git'Fellow <[email protected]> fix: tests Signed-off-by: Git'Fellow <[email protected]> fix: fix tests Signed-off-by: Git'Fellow <[email protected]> fix: add tests Signed-off-by: Git'Fellow <[email protected]> fix: tests
susnux
force-pushed
the
fixingPathShareCheck
branch
from
2cf3087
to
0308001
Compare
This was referenced Sep 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #47713 (tested)
Summary
Check is overly broad because it triggers if the target path starts with the shared folder's path, even if the target path is a sibling or a nested folder that is not actually within the shared folder.
The function should check if the target path is a direct descendant of the shared folder path rather than just starting with it. This can be done by ensuring that the target path either matches the shared path exactly or has a
/immediately following the shared folder path.Checklist